* [PATCH] gdb: fix build failure in amd-dbgapi-target.c
@ 2023-08-23 14:59 Lancelot Six
2023-08-23 15:23 ` Pedro Alves
2023-08-23 17:42 ` Tom Tromey
0 siblings, 2 replies; 4+ messages in thread
From: Lancelot Six @ 2023-08-23 14:59 UTC (permalink / raw)
To: gdb-patches; +Cc: lsix, Lancelot Six
Since b080fe54fb3 "gdb: add inferior-specific breakpoints", the
breakpoint class has an "inferior" member used to handle
inferior-specific breakpoints. This creates a compilation error
in amd_dbgapi_target_breakpoint::check_status which declares a local
variable "inferior *inf".
Fix this by using "struct inferior *inf" instead.
Change-Id: Icc4dc1ba96c7d3ff9d33f9cb384ffcf64eba26fb
---
gdb/amd-dbgapi-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
index e90628c8183..22c269b7992 100644
--- a/gdb/amd-dbgapi-target.c
+++ b/gdb/amd-dbgapi-target.c
@@ -398,7 +398,7 @@ amd_dbgapi_target_breakpoint::re_set ()
void
amd_dbgapi_target_breakpoint::check_status (struct bpstat *bs)
{
- inferior *inf = current_inferior ();
+ struct inferior *inf = current_inferior ();
amd_dbgapi_inferior_info *info = get_amd_dbgapi_inferior_info (inf);
amd_dbgapi_status_t status;
base-commit: 3ce8f906be7a55d8c0375e6d360cc53b456d86ae
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb: fix build failure in amd-dbgapi-target.c
2023-08-23 14:59 [PATCH] gdb: fix build failure in amd-dbgapi-target.c Lancelot Six
@ 2023-08-23 15:23 ` Pedro Alves
2023-08-23 15:45 ` Six, Lancelot
2023-08-23 17:42 ` Tom Tromey
1 sibling, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2023-08-23 15:23 UTC (permalink / raw)
To: Lancelot Six, gdb-patches; +Cc: lsix
On 23/08/23 15:59, Lancelot Six via Gdb-patches wrote:
> Since b080fe54fb3 "gdb: add inferior-specific breakpoints", the
> breakpoint class has an "inferior" member used to handle
> inferior-specific breakpoints. This creates a compilation error
> in amd_dbgapi_target_breakpoint::check_status which declares a local
> variable "inferior *inf".
>
> Fix this by using "struct inferior *inf" instead.
>
> Change-Id: Icc4dc1ba96c7d3ff9d33f9cb384ffcf64eba26fb
Approved-By: Pedro Alves <pedro@palves.net>
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] gdb: fix build failure in amd-dbgapi-target.c
2023-08-23 15:23 ` Pedro Alves
@ 2023-08-23 15:45 ` Six, Lancelot
0 siblings, 0 replies; 4+ messages in thread
From: Six, Lancelot @ 2023-08-23 15:45 UTC (permalink / raw)
To: Pedro Alves, gdb-patches; +Cc: lsix
[AMD Official Use Only - General]
> Approved-By: Pedro Alves <pedro@palves.net>
>
> Thanks,
> Pedro Alves
Thanks,
I just pushed this patch.
Best,
Lancelot.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb: fix build failure in amd-dbgapi-target.c
2023-08-23 14:59 [PATCH] gdb: fix build failure in amd-dbgapi-target.c Lancelot Six
2023-08-23 15:23 ` Pedro Alves
@ 2023-08-23 17:42 ` Tom Tromey
1 sibling, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2023-08-23 17:42 UTC (permalink / raw)
To: Lancelot Six via Gdb-patches; +Cc: Lancelot Six, lsix
>>>>> "Lancelot" == Lancelot Six via Gdb-patches <gdb-patches@sourceware.org> writes:
Lancelot> Since b080fe54fb3 "gdb: add inferior-specific breakpoints", the
Lancelot> breakpoint class has an "inferior" member used to handle
Lancelot> inferior-specific breakpoints. This creates a compilation error
Lancelot> in amd_dbgapi_target_breakpoint::check_status which declares a local
Lancelot> variable "inferior *inf".
Lancelot> Fix this by using "struct inferior *inf" instead.
This kind of thing can go in as obvious.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-23 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-23 14:59 [PATCH] gdb: fix build failure in amd-dbgapi-target.c Lancelot Six
2023-08-23 15:23 ` Pedro Alves
2023-08-23 15:45 ` Six, Lancelot
2023-08-23 17:42 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).