Re: [PATCHv2] gdb: Ignore some stringop-overflow and restrict warnings on sparc

[Tom Tromey <tom@tromey.com>]

>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> For some reason g++ 12.2.1 on sparc produces a spurious warning for
Mark> stringop-overread and restrict in fbsd-tdep.c for some memcpy calls.
Mark> Add new DIAGNOSTIC_IGNORE_STRINGOP_OVERFLOW and
Mark> DIAGNOSTIC_IGNORE_RESTRICT macro to suppress these warnings:

Mark>    gdb::byte_vector desc (sizeof (structsize) + buf->size ());
Mark>    memcpy (desc.data (), &structsize, sizeof (structsize));
Mark> +#if defined (__sparc__)
Mark> +  /* g++ 12.2.1 on sparc seems confused about the vector buf sizes.  */
Mark> +  DIAGNOSTIC_PUSH
Mark> +  DIAGNOSTIC_IGNORE_STRINGOP_OVERFLOW
Mark> +  DIAGNOSTIC_IGNORE_RESTRICT
Mark> +#endif
Mark>    memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ());
Mark> +#if defined (__sparc__)
Mark> +  DIAGNOSTIC_POP
Mark> +#endif

Is there any chance that std::copy or std::memmove would avoid the
warning?  It would be nice if this could be fixed without having to add
a bunch of #if goo.

However, if not, this is ok.

Tom