[PATCH] Remove extra '.' from error message

[PATCH] Remove extra '.' from error message

[Tom Tromey]

A local gdb test failed with this error message:

 Remote communication error.  Target disconnected.: Arg list too long.

The ".:" seemed weird to me.  This patch removes the ".".
---
 gdb/remote.c                             | 4 ++--
 gdb/testsuite/gdb.server/server-kill.exp | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/remote.c b/gdb/remote.c
index ff3d7e5cd32..6fefabac0ce 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -9648,7 +9648,7 @@ remote_target::readchar (int timeout)
       /* no return */
     case SERIAL_ERROR:
       unpush_and_perror (this, _("Remote communication error.  "
-				 "Target disconnected."));
+				 "Target disconnected"));
       /* no return */
     case SERIAL_TIMEOUT:
       break;
@@ -9677,7 +9677,7 @@ remote_target::remote_serial_write (const char *str, int len)
   if (serial_write (rs->remote_desc, str, len))
     {
       unpush_and_perror (this, _("Remote communication error.  "
-				 "Target disconnected."));
+				 "Target disconnected"));
     }
 
   if (rs->got_ctrlc_during_io)
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 4b40913fff6..a0326679714 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -97,7 +97,7 @@ proc_with_prefix test_tstatus {} {
 
     # Force GDB to talk with GDBserver, so that we can get the
     # "connection closed" error.
-    gdb_test "tstatus" {Remote connection closed|Remote communication error\.  Target disconnected\.: Connection reset by peer\.}
+    gdb_test "tstatus" {Remote connection closed|Remote communication error\.  Target disconnected: Connection reset by peer\.}
 }
 
 # Test unwinding with no debug/unwind info, right after the connection
-- 
2.40.1

Re: [PATCH] Remove extra '.' from error message

[John Baldwin]

On 8/4/23 6:23 AM, Tom Tromey via Gdb-patches wrote:
> A local gdb test failed with this error message:
> 
>   Remote communication error.  Target disconnected.: Arg list too long.
> 
> The ".:" seemed weird to me.  This patch removes the ".".

Agreed.

Reviewed-by: John Baldwin <jhb@FreeBSD.org>

-- 
John Baldwin

Re: [PATCH] Remove extra '.' from error message

[Tom Tromey]

>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:

John> On 8/4/23 6:23 AM, Tom Tromey via Gdb-patches wrote:
>> A local gdb test failed with this error message:
>> Remote communication error.  Target disconnected.: Arg list too
>> long.
>> The ".:" seemed weird to me.  This patch removes the ".".

John> Agreed.

John> Reviewed-by: John Baldwin <jhb@FreeBSD.org>

Thanks, I'm checking this in.

Tom