* [PATCH 1/1] python, btrace: Fix some small formatting issues.
@ 2023-05-26 12:30 Felix Willgerodt
2023-05-30 15:51 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Felix Willgerodt @ 2023-05-26 12:30 UTC (permalink / raw)
To: gdb-patches
This can probably go in as obvious, but I wasn't brave enough :)
---
gdb/python/py-record-btrace.c | 5 ++---
gdb/python/py-record.c | 6 ++++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/gdb/python/py-record-btrace.c b/gdb/python/py-record-btrace.c
index 7802a7d9534..7978f3332c6 100644
--- a/gdb/python/py-record-btrace.c
+++ b/gdb/python/py-record-btrace.c
@@ -169,8 +169,8 @@ btpy_insn_or_gap_new (thread_info *tinfo, Py_ssize_t number)
/* Create a new gdb.BtraceList object. */
static PyObject *
-btpy_list_new (thread_info *thread, Py_ssize_t first, Py_ssize_t last, Py_ssize_t step,
- PyTypeObject *element_type)
+btpy_list_new (thread_info *thread, Py_ssize_t first, Py_ssize_t last,
+ Py_ssize_t step, PyTypeObject *element_type)
{
btpy_list_object * const obj = PyObject_New (btpy_list_object,
&btpy_list_type);
@@ -310,7 +310,6 @@ recpy_bt_insn_decoded (PyObject *self, void *closure)
return NULL;
}
-
return PyBytes_FromString (strfile.string ().c_str ());
}
diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c
index 5fc64f6aa78..c96c649b29c 100644
--- a/gdb/python/py-record.c
+++ b/gdb/python/py-record.c
@@ -177,7 +177,8 @@ recpy_end (PyObject *self, void* closure)
/* Create a new gdb.RecordInstruction object. */
PyObject *
-recpy_insn_new (thread_info *thread, enum record_method method, Py_ssize_t number)
+recpy_insn_new (thread_info *thread, enum record_method method,
+ Py_ssize_t number)
{
recpy_element_object * const obj = PyObject_New (recpy_element_object,
&recpy_insn_type);
@@ -273,7 +274,8 @@ recpy_insn_is_speculative (PyObject *self, void *closure)
/* Create a new gdb.RecordFunctionSegment object. */
PyObject *
-recpy_func_new (thread_info *thread, enum record_method method, Py_ssize_t number)
+recpy_func_new (thread_info *thread, enum record_method method,
+ Py_ssize_t number)
{
recpy_element_object * const obj = PyObject_New (recpy_element_object,
&recpy_func_type);
--
2.40.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] python, btrace: Fix some small formatting issues.
2023-05-26 12:30 [PATCH 1/1] python, btrace: Fix some small formatting issues Felix Willgerodt
@ 2023-05-30 15:51 ` Tom Tromey
2023-05-31 7:29 ` Willgerodt, Felix
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2023-05-30 15:51 UTC (permalink / raw)
To: Felix Willgerodt via Gdb-patches; +Cc: Felix Willgerodt
>>>>> Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> writes:
> This can probably go in as obvious, but I wasn't brave enough :)
Seems fine to me! And I agree it is obvious.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] python, btrace: Fix some small formatting issues.
2023-05-30 15:51 ` Tom Tromey
@ 2023-05-31 7:29 ` Willgerodt, Felix
0 siblings, 0 replies; 3+ messages in thread
From: Willgerodt, Felix @ 2023-05-31 7:29 UTC (permalink / raw)
To: Tom Tromey, Felix Willgerodt via Gdb-patches
Thanks, I will be brave enough next time!
I pushed this now.
Felix
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 30. Mai 2023 17:51
> To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> Subject: Re: [PATCH 1/1] python, btrace: Fix some small formatting issues.
>
> >>>>> Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> writes:
>
> > This can probably go in as obvious, but I wasn't brave enough :)
>
> Seems fine to me! And I agree it is obvious.
> Reviewed-By: Tom Tromey <tom@tromey.com>
>
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-31 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 12:30 [PATCH 1/1] python, btrace: Fix some small formatting issues Felix Willgerodt
2023-05-30 15:51 ` Tom Tromey
2023-05-31 7:29 ` Willgerodt, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).