From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/2] gdb: fix crash when getting the value of a label symbol
Date: Thu, 15 Dec 2022 12:28:02 -0700 [thread overview]
Message-ID: <87len8cvr1.fsf@tromey.com> (raw)
In-Reply-To: <871qp023zi.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 15 Dec 2022 13:25:37 +0000")
Andrew> How about I just change to use 'void *' now?
Seems like a good idea to me.
Andrew> How's this?
I have one little nit.
Andrew> + struct type *void_ptr_type
Andrew> + = lookup_pointer_type (builtin_type (var->arch ())->builtin_void);
I think this can use builtin_data_ptr.
Tom
prev parent reply other threads:[~2022-12-15 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 10:28 [PATCH 0/2] Fix crash when accessing symbol value from Python API Andrew Burgess
2022-12-14 10:28 ` [PATCH 1/2] gdb: use gdb_assert not internal_error Andrew Burgess
2022-12-14 16:07 ` Tom Tromey
2022-12-15 13:10 ` Andrew Burgess
2022-12-14 10:28 ` [PATCH 2/2] gdb: fix crash when getting the value of a label symbol Andrew Burgess
2022-12-14 16:17 ` Tom Tromey
2022-12-15 13:25 ` Andrew Burgess
2022-12-15 19:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87len8cvr1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).