From: Tom Tromey <tromey@adacore.com>
To: Aaron Merey <amerey@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Simplify the ui-out progress API
Date: Thu, 10 Mar 2022 10:11:11 -0700 [thread overview]
Message-ID: <87lexhohqo.fsf@tromey.com> (raw)
In-Reply-To: <CAJDtP-Tayt3Y0C1bpCryH2nOD0Oei7--B86Lr5qMKf5o8QmvCQ@mail.gmail.com> (Aaron Merey's message of "Mon, 7 Mar 2022 12:50:31 -0500")
>>>>> "Aaron" == Aaron Merey <amerey@redhat.com> writes:
Aaron> Hi Tom,
Aaron> On Fri, Mar 4, 2022 at 2:30 PM Tom Tromey <tromey@adacore.com> wrote:
>> I noticed that 'progress' is a method on ui-out, but it seems to me
>> that it would be better if the only API were via the progress_meter
>> class. This patch makes this change, changing progress to be a method
>> on the meter itself.
Aaron> LGTM. I agree that it's better to use progress_meter for this API. This
Aaron> change should be fine even if we were to implement progress handling
Aaron> in a ui_out derived class.
Thanks. I'm going to check this in now.
Tom
prev parent reply other threads:[~2022-03-10 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 19:30 Tom Tromey
2022-03-07 17:50 ` Aaron Merey
2022-03-10 17:11 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lexhohqo.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).