From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Small cleanups in gdb/record*.c code
Date: Tue, 16 Apr 2024 11:18:01 -0600 [thread overview]
Message-ID: <87mspt1b1y.fsf@tromey.com> (raw)
In-Reply-To: <cover.1713190701.git.aburgess@redhat.com> (Andrew Burgess's message of "Mon, 15 Apr 2024 15:19:25 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Series of trivial cleanups in the gdb/record*.c code. The first two
Andrew> should have no user visible effects.
Andrew> The third does add a new error case, so I guess a user might hit that,
Andrew> this is all explained in the commit message.
I read through these and they seem fine to me.
It would be good to address Keith's comments about the error message,
but aside from that --
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-16 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 14:19 Andrew Burgess
2024-04-15 14:19 ` [PATCH 1/3] gdb/record: remove unnecessary use of filename_completer Andrew Burgess
2024-04-15 14:19 ` [PATCH 2/3] gdb/record: add an assert in cmd_record_start Andrew Burgess
2024-04-15 14:19 ` [PATCH 3/3] gdb/record: minor clean, remove some unneeded arguments Andrew Burgess
2024-04-15 14:41 ` Eli Zaretskii
2024-04-16 14:12 ` Keith Seitz
2024-04-16 17:18 ` Tom Tromey [this message]
2024-04-17 13:48 ` [PATCH 0/3] Small cleanups in gdb/record*.c code Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mspt1b1y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).