From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Handle unwinding from SEGV on Windows
Date: Mon, 10 Apr 2023 08:38:43 -0600 [thread overview]
Message-ID: <87mt3f7qfg.fsf@tromey.com> (raw)
In-Reply-To: <20230321194240.1766622-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 21 Mar 2023 13:42:40 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> PR win32/30255 points out that a call to a NULL function pointer will
Tom> leave gdb unable to "bt" on Windows.
Tom> I tracked this down to the amd64 windows unwinder. If we treat this
Tom> scenario as if it were a leaf function, unwinding works fine.
Tom> I'm not completely sure this patch is the best way. I considered
Tom> having it check for 'pc==0' -- but then I figured this could affect
Tom> any inaccessible PC, not just the special 0 value.
Tom> No test case because I can't run dejagnu tests on Windows. I tested
Tom> this by hand using the test case in the bug.
Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30255
I'm checking this in.
Tom
prev parent reply other threads:[~2023-04-10 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:42 Tom Tromey
2023-04-10 14:38 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt3f7qfg.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).