From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Avoid manual memory management in go-lang.c
Date: Fri, 17 Feb 2023 17:01:01 -0700 [thread overview]
Message-ID: <87mt5b970i.fsf@tromey.com> (raw)
In-Reply-To: <87edqnlxoc.fsf@redhat.com> (Andrew Burgess's message of "Fri, 17 Feb 2023 22:44:19 +0000")
>> +/* Given a Go symbol, return its package or NULL if unknown. */
>> +extern gdb::unique_xmalloc_ptr<char> go_symbol_package_name
>> + (const struct symbol *sym);
>> +
>> +/* Return the package that BLOCK is in, or NULL if there isn't
>> + one. */
>> +extern gdb::unique_xmalloc_ptr<char> go_block_package_name
>> + (const struct block *block);
Andrew> Maybe replace NULL with nullptr in these comment. But otherwise, this
Andrew> all looks great.
I've done this, thank you.
Tom
next prev parent reply other threads:[~2023-02-18 0:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 1:00 [PATCH 0/2] Fix a crash " Tom Tromey
2023-02-17 1:00 ` [PATCH 1/2] Avoid manual memory management " Tom Tromey
2023-02-17 22:44 ` Andrew Burgess
2023-02-18 0:01 ` Tom Tromey [this message]
2023-02-17 1:00 ` [PATCH 2/2] Fix crash in go_symbol_package_name Tom Tromey
2023-02-17 22:51 ` Andrew Burgess
2023-02-18 0:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt5b970i.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).