public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix JIT reader path creation
@ 2013-12-18 21:12 Sasha Smundak
  2013-12-20 15:33 ` Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: Sasha Smundak @ 2013-12-18 21:12 UTC (permalink / raw)
  To: gdb-patches

Unless the argument of the `jit-reader-load' command is an absolute path, the
JIT reader should be loaded from <jit_reader_dir>/<arg> (the code currently
tries to load it from /<jit_reader_dir> <arg> instead).

Sasha

gdb/Changelog
2013-12-18  Sasha Smundak  <asmundak@google.com>

	* jit.c: (jit_reader_load_command): Fix JIT reader path creation.

diff --git a/gdb/jit.c b/gdb/jit.c
index fde79e5..d216b8a 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -214,7 +214,7 @@ jit_reader_load_command (char *args, int from_tty)
   if (IS_ABSOLUTE_PATH (args))
     so_name = xstrdup (args);
   else
-    so_name = xstrprintf ("%s%s%s", SLASH_STRING, jit_reader_dir, args);
+    so_name = xstrprintf ("%s%s%s", jit_reader_dir, SLASH_STRING, args);
   prev_cleanup = make_cleanup (xfree, so_name);
 
   loaded_jit_reader = jit_reader_load (so_name);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix JIT reader path creation
  2013-12-18 21:12 [PATCH] Fix JIT reader path creation Sasha Smundak
@ 2013-12-20 15:33 ` Tom Tromey
  2013-12-20 18:45   ` Alexander Smundak
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2013-12-20 15:33 UTC (permalink / raw)
  To: Sasha Smundak; +Cc: gdb-patches

>>>>> "Sasha" == Sasha Smundak <asmundak@google.com> writes:

Sasha> 2013-12-18  Sasha Smundak  <asmundak@google.com>
Sasha> 	* jit.c: (jit_reader_load_command): Fix JIT reader path creation.

Ok.

Let me know if you need me to push this for you.

Tom

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix JIT reader path creation
  2013-12-20 15:33 ` Tom Tromey
@ 2013-12-20 18:45   ` Alexander Smundak
  2014-01-06 21:57     ` Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Smundak @ 2013-12-20 18:45 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On Fri, Dec 20, 2013 at 7:33 AM, Tom Tromey <tromey@redhat.com> wrote:
>
> Let me know if you need me to push this for you.

Yes, please. I don't know the procedure.

Sasha

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix JIT reader path creation
  2013-12-20 18:45   ` Alexander Smundak
@ 2014-01-06 21:57     ` Tom Tromey
  0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2014-01-06 21:57 UTC (permalink / raw)
  To: Alexander Smundak; +Cc: gdb-patches

>>>>> "Alexander" == Alexander Smundak <asmundak@google.com> writes:

Tom> Let me know if you need me to push this for you.

Alexander> Yes, please. I don't know the procedure.

Sorry about the delay.
I'm checking it in now.

Tom

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-06 21:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-18 21:12 [PATCH] Fix JIT reader path creation Sasha Smundak
2013-12-20 15:33 ` Tom Tromey
2013-12-20 18:45   ` Alexander Smundak
2014-01-06 21:57     ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).