From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix bug in DAP handling of 'pause' requests
Date: Mon, 27 Nov 2023 08:54:38 -0700 [thread overview]
Message-ID: <87o7fffayp.fsf@tromey.com> (raw)
In-Reply-To: <20231117174901.4111817-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 17 Nov 2023 10:49:01 -0700")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> While working on cancellation, I noticed that a DAP 'pause' request
Tom> would set the "do not emit the continue" flag. This meant that a
Tom> subsequent request that should provoke a 'continue' event would
Tom> instead suppress the event.
Tom> I then tried writing a more obvious test case for this, involving an
Tom> inferior call -- and discovered that gdb.events.cont does not fire for
Tom> an inferior call.
Tom> This patch installs a new event listener for gdb.events.inferior_call
Tom> and arranges for this to emit continue and stop events when
Tom> appropriate. It also fixes the original bug, by adding a check to
Tom> exec_and_expect_stop.
I'm going to check this in on trunk & the gdb-14 branch now.
Tom
prev parent reply other threads:[~2023-11-27 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 17:49 Tom Tromey
2023-11-27 15:54 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7fffayp.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).