From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix htab_t pretty-printer for NULL values
Date: Sat, 11 Mar 2023 08:09:59 -0700 [thread overview]
Message-ID: <87o7oze33s.fsf@tromey.com> (raw)
In-Reply-To: <41ac36c3-2c31-c78b-9d48-57be9402bf14@simark.ca> (Simon Marchi's message of "Fri, 10 Mar 2023 22:15:50 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + gdb_test -prompt $outer_prompt_re "print (htab_t) 0x0" \
>> + [string_to_regexp " = (null)"]
Simon> Instead of hardcoding (null), what about not selecting the pretty
Simon> printer when the value is nullptr? Like this:
That seems fine, how about we go with your patch?
Simon> Can the value's value change after a pretty printer was selected for it?
Nope.
Tom
prev parent reply other threads:[~2023-03-11 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 20:56 Tom Tromey
2023-03-11 3:15 ` Simon Marchi
2023-03-11 15:09 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7oze33s.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).