Re: [PATCH] Clean up attribute reprocessing

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> This patch introduces a new read_toplevel_die function and changes a
Tom> few spots to call it.  This is easily done because reading the
Tom> toplevel DIE is already special.

Tom> I left the reprocessing flag and associated checks in attribute.  It
Tom> could be stripped out, but I am not sure it would provide much value
Tom> (maybe some iota of performance).

I found one small bug in this patch:

Tom> +  /* Push an element into ATTRIBUTES.  */
Tom> +  auto push_back = [&] (struct attribute *attr)
Tom> +    {
Tom> +      gdb_assert (next_attr_idx <= ARRAY_SIZE (attributes));

This assert is off-by-one so it didn't really check what it was supposed
to check.

Tom