public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Simon Marchi via Gdb-patches <>
Cc: Simon Marchi <>
Subject: Re: [PATCH] gdb: introduce bp_loc_tracepoint
Date: Wed, 18 Jan 2023 10:46:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Simon Marchi via Gdb-patches's message of "Fri, 25 Nov 2022 13:56:14 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <> writes:

Simon> Because locations for tracepoints have the bp_loc_other type,
Simon> bl_address_is_meaningful started to return false for them, where it
Simon> returned true before.  This made update_global_location_list skip the
Simon> part where it calls swap_insertion.

Simon> I think this can be solved by introduced a new bp_loc_tracepoint
Simon> bp_loc_type.

FWIW this patch looks good to me.


  parent reply	other threads:[~2023-01-18 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 18:56 Simon Marchi
2022-12-07 19:28 ` Simon Marchi
2023-01-10 16:25 ` Simon Marchi
2023-01-18 17:46 ` Tom Tromey [this message]
2023-03-17 20:36   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).