From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: introduce bp_loc_tracepoint
Date: Fri, 17 Mar 2023 16:36:50 -0400 [thread overview]
Message-ID: <a3c0a66a-3c43-1b15-3d22-c5d692bd0a9f@polymtl.ca> (raw)
In-Reply-To: <87o7qv20sk.fsf@tromey.com>
On 1/18/23 12:46, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> Because locations for tracepoints have the bp_loc_other type,
> Simon> bl_address_is_meaningful started to return false for them, where it
> Simon> returned true before. This made update_global_location_list skip the
> Simon> part where it calls swap_insertion.
>
> Simon> I think this can be solved by introduced a new bp_loc_tracepoint
> Simon> bp_loc_type.
>
> FWIW this patch looks good to me.
>
> Tom
Thanks, pushed.
Simon
prev parent reply other threads:[~2023-03-17 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 18:56 Simon Marchi
2022-12-07 19:28 ` Simon Marchi
2023-01-10 16:25 ` Simon Marchi
2023-01-18 17:46 ` Tom Tromey
2023-03-17 20:36 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c0a66a-3c43-1b15-3d22-c5d692bd0a9f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).