From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: remove unneeded value_address call in value_cast_structs
Date: Fri, 04 Mar 2022 13:02:50 -0700 [thread overview]
Message-ID: <87o82lqydx.fsf@tromey.com> (raw)
In-Reply-To: <20220216045314.813723-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 15 Feb 2022 23:53:14 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> - addr2 -= value_address (v) + value_embedded_offset (v);
Simon> + addr2 -= value_embedded_offset (v);
Thank you. I appreciated your long commentary.
I think this is ok, especially if it passed the gdb.cp tests :)
Sometimes I wonder if we could get rid of all this "embedded offset"
stuff. It's an endless source of confusion, at least for me.
Tom
next prev parent reply other threads:[~2022-03-04 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 4:53 Simon Marchi
2022-03-04 20:02 ` Tom Tromey [this message]
2022-03-05 0:42 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82lqydx.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).