public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Try searching for auto-load script using .gnu_debuglink
Date: Fri, 04 Mar 2022 08:56:09 -0700	[thread overview]
Message-ID: <87o82lu2xy.fsf@tromey.com> (raw)
In-Reply-To: <20220223033518.79309-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Tue, 22 Feb 2022 22:35:18 -0500")

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> For example if the parent's filename is "/usr/lib/libxyz.so" and the
Aaron> name in its .gnu_debuglink section is "libxyz.so.debug", then
Aaron> if no auto-load script is otherwise found the search will be
Aaron> repeated with the filename "/usr/lib/libxyz.so.debug".

Seems reasonable.

Aaron> +      char *debuglink = bfd_get_debug_link_info (parent->obfd, &crc32);

bfd_get_debug_link_info says it returns a malloc'd pointer, so I think
this is a memory leak.  Using gdb::unique_xmalloc_ptr<char> would solve
this.

Tom

  reply	other threads:[~2022-03-04 15:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23  3:35 Aaron Merey
2022-03-04 15:56 ` Tom Tromey [this message]
2022-03-08 22:41   ` Aaron Merey
2022-03-09  0:26     ` Tom Tromey
2022-03-09  1:42       ` Aaron Merey
2022-03-10 17:57     ` Pedro Alves
2022-03-10 20:16       ` Aaron Merey
2022-03-10 20:22         ` Aaron Merey
2022-03-10 20:43           ` Tom Tromey
2022-03-11  9:32           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o82lu2xy.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).