From: Aaron Merey <amerey@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Try searching for auto-load script using .gnu_debuglink
Date: Thu, 10 Mar 2022 15:22:43 -0500 [thread overview]
Message-ID: <CAJDtP-THAwx5c+M49mApgcvQWJU4EyOOO2MtpxxxTLUR5kvF-g@mail.gmail.com> (raw)
In-Reply-To: <CAJDtP-Th9CGxQ7PM_+xS6vyoyV5c7CPcp3-tMBxyoB-Gu38P6A@mail.gmail.com>
On Thu, Mar 10, 2022 at 3:16 PM Aaron Merey <amerey@redhat.com> wrote:
>
> Hi Pedro,
>
> On Thu, Mar 10, 2022 at 1:26 PM Pedro Alves <pedro@palves.net> wrote:
> >
> > On 2022-03-08 22:41, Aaron Merey via Gdb-patches wrote:
> > > + auto_load_debug_printf
> > > + ("auto-load: Stripped .exe suffix, retrying with \"%s\".",
> > > + realname.get ());
> > > +
> >
> > With "auto-load:" in the fmt, doesn't gdb print "auto-load" twice?
>
> This was fixed in the second version of the patch I posted:
>
> On Tue, Mar 8, 2022 at 5:41 PM Aaron Merey <amerey@redhat.com> wrote:
> > + auto_load_debug_printf
> > + ("Debug filename mismatch, retrying with \"%s\".",
> > + p_realname.c_str ());
>
> The first version repeated "auto-load" because I based the message
> on a pre-existing call to auto_load_debug_printf in auto_load_objfile_script
> which contains a repeated "auto-load". That should be fixed and I will post
> a patch for this.
Sorry Pedro, I mistook the function call you quoted for the call I added and
later fixed. The repeated auto-load you quoted was copied verbatim from a
pre-existing call to auto_load_debug_printf and was not fixed in the patch
that was merged. But like I said I will post a fix for this.
Aaron
next prev parent reply other threads:[~2022-03-10 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 3:35 Aaron Merey
2022-03-04 15:56 ` Tom Tromey
2022-03-08 22:41 ` Aaron Merey
2022-03-09 0:26 ` Tom Tromey
2022-03-09 1:42 ` Aaron Merey
2022-03-10 17:57 ` Pedro Alves
2022-03-10 20:16 ` Aaron Merey
2022-03-10 20:22 ` Aaron Merey [this message]
2022-03-10 20:43 ` Tom Tromey
2022-03-11 9:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDtP-THAwx5c+M49mApgcvQWJU4EyOOO2MtpxxxTLUR5kvF-g@mail.gmail.com \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).