* [PATCH] gdb: additional settings for emacs in .dir-locals.el
@ 2021-05-17 14:57 Andrew Burgess
2021-05-17 18:16 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Burgess @ 2021-05-17 14:57 UTC (permalink / raw)
To: gdb-patches
Two additional settings for developers who use emacs:
1. Set brace-list-open to 0 for C and C++ modes, this ensures we
format things like:
enum blah
{
....
};
Instead of the default for the emacs GNU style:
enum blah
{
...
};
The former seems to be the GDB style.
2. Set sentence-end-double-space to t. This is actually the default
value for this setting, but if anyone has customised this to nil in
general, then forcing this back to t for GDB files will give a
better behaviour for the paragraph filling.
gdb/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
gdbserver/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
gdbsupport/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
---
gdb/.dir-locals.el | 7 ++++---
gdb/ChangeLog | 5 +++++
gdbserver/.dir-locals.el | 7 ++++---
gdbserver/ChangeLog | 5 +++++
gdbsupport/.dir-locals.el | 7 ++++---
gdbsupport/ChangeLog | 5 +++++
6 files changed, 27 insertions(+), 9 deletions(-)
diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el
index 467a9049676..16641bb8831 100644
--- a/gdb/.dir-locals.el
+++ b/gdb/.dir-locals.el
@@ -22,13 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
- (eval . (c-set-offset 'brace-list-open 0))
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -37,7 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
- (eval . (c-set-offset 'brace-list-open 0))
))
)
diff --git a/gdbserver/.dir-locals.el b/gdbserver/.dir-locals.el
index 467a9049676..16641bb8831 100644
--- a/gdbserver/.dir-locals.el
+++ b/gdbserver/.dir-locals.el
@@ -22,13 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
- (eval . (c-set-offset 'brace-list-open 0))
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -37,7 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
- (eval . (c-set-offset 'brace-list-open 0))
))
)
diff --git a/gdbsupport/.dir-locals.el b/gdbsupport/.dir-locals.el
index 467a9049676..16641bb8831 100644
--- a/gdbsupport/.dir-locals.el
+++ b/gdbsupport/.dir-locals.el
@@ -22,13 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
- (eval . (c-set-offset 'brace-list-open 0))
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -37,7 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
- (eval . (c-set-offset 'brace-list-open 0))
))
)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb: additional settings for emacs in .dir-locals.el
2021-05-17 14:57 [PATCH] gdb: additional settings for emacs in .dir-locals.el Andrew Burgess
@ 2021-05-17 18:16 ` Tom Tromey
2021-05-17 18:52 ` Andrew Burgess
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2021-05-17 18:16 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Two additional settings for developers who use emacs:
Andrew> 1. Set brace-list-open to 0 for C and C++ modes, this ensures we
Andrew> format things like:
I didn't understand the diff here, since it seems like this is already
done?
Andrew> 2. Set sentence-end-double-space to t. This is actually the default
Andrew> value for this setting, but if anyone has customised this to nil in
Andrew> general, then forcing this back to t for GDB files will give a
Andrew> better behaviour for the paragraph filling.
Looks good. Thanks.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb: additional settings for emacs in .dir-locals.el
2021-05-17 18:16 ` Tom Tromey
@ 2021-05-17 18:52 ` Andrew Burgess
2021-05-17 19:41 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Burgess @ 2021-05-17 18:52 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
* Tom Tromey <tom@tromey.com> [2021-05-17 12:16:57 -0600]:
> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>
> Andrew> Two additional settings for developers who use emacs:
> Andrew> 1. Set brace-list-open to 0 for C and C++ modes, this ensures we
> Andrew> format things like:
>
> I didn't understand the diff here, since it seems like this is already
> done?
I'm having some sort of "special" day today.
Here's the _actual_ patch I'm proposing.
Thanks,
Andrew
---
commit 43abbec1c3a4de080029e6643a4de87434608d59
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date: Mon May 17 13:09:22 2021 +0100
gdb: additional settings for emacs in .dir-locals.el
Two additional settings for developers who use emacs:
1. Set brace-list-open to 0 for C and C++ modes, this ensures we
format things like:
enum blah
{
....
};
Instead of the default for the emacs GNU style:
enum blah
{
...
};
The former seems to be the GDB style.
2. Set sentence-end-double-space to t. This is actually the default
value for this setting, but if anyone has customised this to nil in
general, then forcing this back to t for GDB files will give a
better behaviour for the paragraph filling.
gdb/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
gdbserver/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
gdbsupport/ChangeLog:
* .dir-locals.el: Set sentence-end-double-space for all modes, and
set brace-list-open to 0 for C and C++ modes.
diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el
index 94c07dc6850..16641bb8831 100644
--- a/gdb/.dir-locals.el
+++ b/gdb/.dir-locals.el
@@ -22,12 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -36,6 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
)
diff --git a/gdbserver/.dir-locals.el b/gdbserver/.dir-locals.el
index 94c07dc6850..16641bb8831 100644
--- a/gdbserver/.dir-locals.el
+++ b/gdbserver/.dir-locals.el
@@ -22,12 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -36,6 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
)
diff --git a/gdbsupport/.dir-locals.el b/gdbsupport/.dir-locals.el
index 94c07dc6850..16641bb8831 100644
--- a/gdbsupport/.dir-locals.el
+++ b/gdbsupport/.dir-locals.el
@@ -22,12 +22,14 @@
(tcl-mode . ((tcl-indent-level . 4)
(tcl-continued-indent-level . 4)
(indent-tabs-mode . t)))
- (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")))
+ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
+ (sentence-end-double-space . t)))
(c-mode . ((c-file-style . "GNU")
(mode . c++)
(indent-tabs-mode . t)
(tab-width . 8)
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
(c++-mode . ((eval . (when (fboundp 'c-toggle-comment-style)
@@ -36,6 +38,7 @@
(tab-width . 8)
(c-file-style . "GNU")
(c-basic-offset . 2)
+ (eval . (c-set-offset 'brace-list-open 0))
(eval . (c-set-offset 'innamespace 0))
))
)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb: additional settings for emacs in .dir-locals.el
2021-05-17 18:52 ` Andrew Burgess
@ 2021-05-17 19:41 ` Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2021-05-17 19:41 UTC (permalink / raw)
To: Andrew Burgess; +Cc: Tom Tromey, gdb-patches
Andrew> I'm having some sort of "special" day today.
I know the feeling.
Andrew> Here's the _actual_ patch I'm proposing.
Looks great. Thanks.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-17 19:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 14:57 [PATCH] gdb: additional settings for emacs in .dir-locals.el Andrew Burgess
2021-05-17 18:16 ` Tom Tromey
2021-05-17 18:52 ` Andrew Burgess
2021-05-17 19:41 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).