From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/remote: fix qRcmd error handling
Date: Fri, 26 Apr 2024 10:54:15 -0600 [thread overview]
Message-ID: <87plucf4js.fsf@tromey.com> (raw)
In-Reply-To: <c1a17c26f2d4933e0748dfcab6aff53bc740cef5.1713775525.git.aburgess@redhat.com> (Andrew Burgess's message of "Mon, 22 Apr 2024 09:45:47 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Currently, gdbserver doesn't exercise this path so it's not possible
Andrew> to write a simple test for this case. When gdbserver wishes to print
Andrew> output it sends back an 'O' string output packet, these packets are
Andrew> handled earlier in the process. Then once gdbserver has finished
Andrew> sending output an 'OK' packet is sent.
I think I must have misread this patch earlier. Thanks for your
patience & explanations. I think it is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-26 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:45 Andrew Burgess
[not found] ` <8734rdsb51.fsf@tromey.com>
2024-04-23 20:04 ` Andrew Burgess
2024-04-24 21:39 ` Tom Tromey
2024-04-26 15:12 ` Andrew Burgess
2024-04-26 16:54 ` Tom Tromey [this message]
2024-04-29 9:02 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plucf4js.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).