From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/remote: fix qRcmd error handling
Date: Wed, 24 Apr 2024 15:39:34 -0600 [thread overview]
Message-ID: <87zfticueh.fsf@tromey.com> (raw)
In-Reply-To: <87v847u9q9.fsf@redhat.com> (Andrew Burgess's message of "Tue, 23 Apr 2024 21:04:14 +0100")
>> The patch itself seems reasonable to me, but at the same time, isn't the
>> behavior you describe also fine?
>>
>> The docs describe "OK", other "O" output packets, the "E" response, and
>> the empty response. It seems to me that any other response could
>> reasonably be treated as an error.
Andrew> The behaviour I'm restoring is documented, see the 'OUTPUT' entry in the
Andrew> 'Reply:' list:
Andrew> 'OUTPUT'
Andrew> A command response with the hex encoded output string OUTPUT.
I thought your patch was concerned with changing the output of responses
other than 'E' or 'O'... did I misunderstand that?
Tom
next prev parent reply other threads:[~2024-04-24 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:45 Andrew Burgess
[not found] ` <8734rdsb51.fsf@tromey.com>
2024-04-23 20:04 ` Andrew Burgess
2024-04-24 21:39 ` Tom Tromey [this message]
2024-04-26 15:12 ` Andrew Burgess
2024-04-26 16:54 ` Tom Tromey
2024-04-29 9:02 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfticueh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).