Re: [PATCH v4 6/6] gdb/testsuite: Add kfail in gdb.threads/threadcrash.exp on 32-bit arm targets

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Tom,

Thank you for this series!

Tom de Vries <tdevries@suse.de> writes:

> On 3/8/24 10:33, Tom de Vries wrote:
>> +	if { $have_kfail } {
>> +	    kfail $test
>> +	} else {
>
> This needs and additional fixup:
> ...
> diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp
> b/gdb/testsuite/gdb.threads/threadcrash.exp
> index 7839f5c358e..3679cdc69fa 100644
> --- a/gdb/testsuite/gdb.threads/threadcrash.exp
> +++ b/gdb/testsuite/gdb.threads/threadcrash.exp
> @@ -123,7 +123,8 @@ proc do_full_test { phase } {
>      } else {
>  	set have_kfail [expr [string equal $phase gcore] && [is_aarch32_target]]
>  	if { $have_kfail } {
> -	    kfail $test
> +	    kfail corefiles/31294 $test
> +	    return
>  	} else {
>  	    fail $test
>  	}
> ...
>
> Thiago, you mentioned you could reproduce the problem, can you check whether this catches
> it?

I applied the patch series plus the fixup above to upstream commit
2755241d02d7 ("Add return value to DAP scope"), and I actually can't
reproduce the problem anymore, not sure why. The threads' backtraces
look reasonable. The only "??" are in linux/arm/clone.S:74 from
libc.so.6.

I put the gdb.log here, if there's interest:

https://people.linaro.org/~thiago.bauermann/gdb-pr-31294/gdb.log

--
Thiago