public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 2/6] gdb/testsuite: Fix gdb.threads/threadcrash.exp with check-readmore
Date: Wed, 13 Mar 2024 11:17:36 -0600	[thread overview]
Message-ID: <87wmq6m4pb.fsf@tromey.com> (raw)
In-Reply-To: <20240308093342.26745-3-tdevries@suse.de> (Tom de Vries's message of "Fri, 8 Mar 2024 10:33:38 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Fix this by rewriting the regexps in a "^\r\n$hs$regexp$hs$eol" style, where:
Tom> - hs is: \[^\n\]* (horizontal space), and
Tom> - eol is (?=\r\n) (look-ahead end-of-line).

Tom> It also turned out to be necessary to drop the -lbl switch, and introduce a
Tom> corresponding explicit clause.  The -lbl clause is placed ALAP, and
Tom> consequently allowed the default fail clause to trigger.

I feel like often we'd like tests to work "line by line" in the sense
that each pattern is matched against each line in isolation.  Maybe
someday we should add a new proc that works this way.

Tom

  reply	other threads:[~2024-03-13 17:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  9:33 [PATCH v4 0/6] Fixes to gdb.threads/threadcrash.exp Tom de Vries
2024-03-08  9:33 ` [PATCH v4 1/6] gdb/testsuite: Reduce indentation in gdb.threads/threadcrash.exp Tom de Vries
2024-03-13 17:12   ` Tom Tromey
2024-03-08  9:33 ` [PATCH v4 2/6] gdb/testsuite: Fix gdb.threads/threadcrash.exp with check-readmore Tom de Vries
2024-03-13 17:17   ` Tom Tromey [this message]
2024-03-08  9:33 ` [PATCH v4 3/6] gdb/testsuite: Use _inferior_thread_count in gdb.threads/threadcrash.exp Tom de Vries
2024-03-08  9:33 ` [PATCH v4 4/6] gdb/testsuite: Simplify gdb.threads/threadcrash.exp Tom de Vries
2024-03-08  9:33 ` [PATCH v4 5/6] gdb/testsuite: Reduce gdb.threads/threadcrash.exp reliance on libc symbols Tom de Vries
2024-03-08  9:33 ` [PATCH v4 6/6] gdb/testsuite: Add kfail in gdb.threads/threadcrash.exp on 32-bit arm targets Tom de Vries
2024-03-08 10:24   ` Tom de Vries
2024-03-08 23:57     ` Thiago Jung Bauermann
2024-03-11 10:15       ` Tom de Vries
2024-03-11 18:10         ` Thiago Jung Bauermann
2024-03-11 23:03           ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmq6m4pb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).