From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/6] Implement DAP cancellation
Date: Tue, 05 Dec 2023 10:17:37 +0100 [thread overview]
Message-ID: <87plzlrosu.fsf@adacore.com> (raw)
In-Reply-To: <20231201-dap-cancel-v1-0-872022fc328a@adacore.com> (Tom Tromey's message of "Fri, 01 Dec 2023 08:40:56 -0700")
Tom Tromey <tromey@adacore.com> writes:
> DAP specifies a way to cancel requests. Previously, I didn't
> implement this, because it didn't seem necessary. However, I realized
> later that a 'repl' evaluation can cause the inferior to continue (or
> gdb to invoke a long-running CLI or Python command), and a request
> like this will not finish -- cancellation is necessary.
>
> This series implements this feature. I've split it into bite-sized
> pieces.
>
> Tested on x86-64 Fedora 38.
>
> ---
> Tom Tromey (6):
> Clean up handling of DAP not-stopped response
> Move DAP JSON reader to its own thread
> Introduce gdb.interrupt
> Rename a couple of DAP procs in the testsuite
> Catch BaseException in send_gdb_with_response
> Implement DAP cancellation
>
> gdb/NEWS | 2 +
> gdb/doc/gdb.texinfo | 16 ++++++
> gdb/doc/python.texi | 11 ++++
> gdb/python/lib/gdb/dap/server.py | 115 ++++++++++++++++++++++++++++++++++++--
> gdb/python/lib/gdb/dap/startup.py | 4 +-
> gdb/python/python.c | 19 +++++++
> gdb/testsuite/gdb.dap/pause.exp | 71 +++++++++++++++++++++++
> gdb/testsuite/lib/dap-support.exp | 10 ++--
> 8 files changed, 236 insertions(+), 12 deletions(-)
> ---
> base-commit: 946df73fa09e782b15f75fc82729bff6a00d2554
> change-id: 20231201-dap-cancel-2c292d80ba37
>
> Best regards,
Beside my remark re. BaseException, nothing more to add, this looks good
to me. For the series:
Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com>
prev parent reply other threads:[~2023-12-05 9:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:40 Tom Tromey
2023-12-01 15:40 ` [PATCH 1/6] Clean up handling of DAP not-stopped response Tom Tromey
2023-12-01 15:40 ` [PATCH 2/6] Move DAP JSON reader to its own thread Tom Tromey
2023-12-01 15:40 ` [PATCH 3/6] Introduce gdb.interrupt Tom Tromey
2023-12-01 15:56 ` Eli Zaretskii
2023-12-11 15:49 ` Tom Tromey
2023-12-01 15:41 ` [PATCH 4/6] Rename a couple of DAP procs in the testsuite Tom Tromey
2023-12-01 15:41 ` [PATCH 5/6] Catch BaseException in send_gdb_with_response Tom Tromey
2023-12-01 16:29 ` Kévin Le Gouguec
2023-12-01 17:51 ` Tom Tromey
2023-12-01 15:41 ` [PATCH 6/6] Implement DAP cancellation Tom Tromey
2023-12-01 15:57 ` Eli Zaretskii
2023-12-11 15:05 ` Tom Tromey
2023-12-11 15:44 ` Eli Zaretskii
2023-12-05 9:17 ` Kévin Le Gouguec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plzlrosu.fsf@adacore.com \
--to=legouguec@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).