From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] Implement DAP cancellation
Date: Mon, 11 Dec 2023 17:44:58 +0200 [thread overview]
Message-ID: <83fs08vj45.fsf@gnu.org> (raw)
In-Reply-To: <87edfsg4p8.fsf@tromey.com> (message from Tom Tromey on Mon, 11 Dec 2023 08:05:23 -0700)
> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
> Date: Mon, 11 Dec 2023 08:05:23 -0700
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Tom Tromey <tromey@adacore.com>
> >> Date: Fri, 01 Dec 2023 08:41:02 -0700
> >>
> >> This implements DAP cancellation. A new object is introduced that
> >> handles the details of cancellation. While cancellation is inherently
> >> racy, this code attempts to make it so that gdb doesn't inadvertently
> >> cancel the wrong request.
> >>
> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30472
> >> ---
> >> gdb/doc/gdb.texinfo | 16 +++++++
> >> gdb/python/lib/gdb/dap/server.py | 91 ++++++++++++++++++++++++++++++++++++++--
> >> gdb/testsuite/gdb.dap/pause.exp | 71 +++++++++++++++++++++++++++++++
> >> 3 files changed, 175 insertions(+), 3 deletions(-)
>
> Eli> Thanks, the documentation part is OK.
>
> Eli> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
> Thanks. I realized I should start adding NEWS entries for DAP changes.
>
> Assuming the earlier one is approved:
>
> +* Debugger Adapter Protocol changes
> +
> + ** GDB now emits the "process" event.
> +
>
> ... then for this cancel patch I'd propose adding:
>
> ** GDB now supports the "cancel" request.
This is OK.
Approved-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-12-11 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:40 [PATCH 0/6] " Tom Tromey
2023-12-01 15:40 ` [PATCH 1/6] Clean up handling of DAP not-stopped response Tom Tromey
2023-12-01 15:40 ` [PATCH 2/6] Move DAP JSON reader to its own thread Tom Tromey
2023-12-01 15:40 ` [PATCH 3/6] Introduce gdb.interrupt Tom Tromey
2023-12-01 15:56 ` Eli Zaretskii
2023-12-11 15:49 ` Tom Tromey
2023-12-01 15:41 ` [PATCH 4/6] Rename a couple of DAP procs in the testsuite Tom Tromey
2023-12-01 15:41 ` [PATCH 5/6] Catch BaseException in send_gdb_with_response Tom Tromey
2023-12-01 16:29 ` Kévin Le Gouguec
2023-12-01 17:51 ` Tom Tromey
2023-12-01 15:41 ` [PATCH 6/6] Implement DAP cancellation Tom Tromey
2023-12-01 15:57 ` Eli Zaretskii
2023-12-11 15:05 ` Tom Tromey
2023-12-11 15:44 ` Eli Zaretskii [this message]
2023-12-05 9:17 ` [PATCH 0/6] " Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fs08vj45.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).