From: Tom Tromey <tromey@adacore.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix off-by-one in call to vector::reserve
Date: Fri, 18 Aug 2023 13:02:54 -0600 [thread overview]
Message-ID: <87pm3kw4v5.fsf@tromey.com> (raw)
In-Reply-To: <3c557b21-d49b-cbc8-de49-237a52f8a2fb@FreeBSD.org> (John Baldwin's message of "Fri, 18 Aug 2023 09:15:06 -0700")
John> Pedantically speaking I would probably write it as '1 + args.size()' as the
John> extra pointer is pushed first followed by a copy of all the items in args
John> (that is, trying to make the expression list the sub-sizes in the same order
John> they are added to the vector).
Sounds good, I'll do it.
Tom
prev parent reply other threads:[~2023-08-18 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 14:03 Tom Tromey
2023-08-18 16:15 ` John Baldwin
2023-08-18 19:02 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm3kw4v5.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).