Re: [PATCH v5] gdb/DAP Fix disassemble bug

[Tom Tromey <tromey@adacore.com>]

>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

Thanks again for working on this.
I'm sorry it took so long for me to get back to it.

Simon> +# Disassemble "backwards"
Simon> +def _disasm_backwards(

This should be marked @in_gdb_thread.

Simon> +    # We take an arbitrary jump backwards
Simon> +    # Guessing that an instruction averages at 8 bytes
Simon> +    start = end_pc - 4 * offset

I don't understand the relation between the comment and the code
here... I thought it was just a typo but later 8 is used, so I don't
know.

Simon> +            tmp = []
Simon> +            # fill remaining ins with "invalid values" as per DAP spec
Simon> +            for i in range(0, offset - len(instructions)):
Simon> +                tmp.append({"addr": 0, "asm": "unknown"})

I guess this could be:

    tmp = [{"addr": 0, "asm": "unknown"}] * (offset - len(instructions))

Tom