public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] PowerPC, add support for recording pipe2 system call.
@ 2022-10-20 23:58 Carl Love
  2022-10-21 15:20 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Carl Love @ 2022-10-20 23:58 UTC (permalink / raw)
  To: gdb-patches; +Cc: Ulrich Weigand, Will Schmidt, cel


GCC maintainers:

The pipe2 system call support for gdb record is missing.  The missing
support results in gdb.reverse/pipe-reverse.exp a single test failure.

This patch adds the needed support for the pipe2 system call on Power
10 with the Fedora 36 distro.

The patch has been tested on Power 10 with no regression failures.

Please let me know if this patch is acceptable for mainline.  Thanks.

                 Carl Love


---------------------------
PowerPC, add support for recording pipe2 system call.

Test gdb.reverse/pipe-reverse.exp fails on Power 10 running the fedora 36
distro.  The gdb record error message is:

  Process record and replay target doesn't support syscall number 317.

System call 317 on PowerPC maps to the pipe2 system call.

This patch adds support for the missing pipe2 system call for PowerPC.

Patch fixes the test failure in gdb.reverse/pipe-reverse.exp.

The patch has been tested on Power 10 with no regression failures.
---
 gdb/ppc-linux-tdep.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index 14800619cbe..cc5a26431ba 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -1400,6 +1400,8 @@ ppc_canonicalize_syscall (int syscall, int wordsize)
       else
 	result = gdb_sys_fstatat64;
     }
+  else if (syscall == 317)
+    result = gdb_sys_pipe2;
   else if (syscall == 336)
     result = gdb_sys_recv;
   else if (syscall == 337)
-- 
2.37.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PowerPC, add support for recording pipe2 system call.
  2022-10-20 23:58 [PATCH] PowerPC, add support for recording pipe2 system call Carl Love
@ 2022-10-21 15:20 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-10-21 15:20 UTC (permalink / raw)
  To: Carl Love via Gdb-patches; +Cc: Carl Love, Ulrich Weigand

Carl> GCC maintainers:

Hmmm.... :)

Carl> The pipe2 system call support for gdb record is missing.  The missing
Carl> support results in gdb.reverse/pipe-reverse.exp a single test failure.

Carl> This patch adds the needed support for the pipe2 system call on Power
Carl> 10 with the Fedora 36 distro.

Carl> The patch has been tested on Power 10 with no regression failures.

Carl> Please let me know if this patch is acceptable for mainline.  Thanks.

Looks good to me.  Thank you for doing this.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-21 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 23:58 [PATCH] PowerPC, add support for recording pipe2 system call Carl Love
2022-10-21 15:20 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).