* [PATCH] [gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp
@ 2024-02-26 14:17 Tom de Vries
2024-02-26 14:53 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2024-02-26 14:17 UTC (permalink / raw)
To: gdb-patches
In commit 52498004a34 ("gdb/testsuite: handle long filenames in
gdb.base/startup-with-shell.exp") we fixed a FAIL reported by the Linaro CI:
...
(gdb) print argv[1]
$1 = 0xfffed978 "<snip>/startup-with-shell/unique-file.unique-e"...
(gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; \
run_args = *.unique-extension: first argument expanded
...
PR testsuite/31410 reports a similar failure:
...
(gdb) print argv[1]
$1 = 0xfffeda96 "<snip>/startup-with-shell/*.unique-extens"...
(gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = off; \
run_args = *.unique-extension: first argument not expanded
...
Fix this in the same way, using "set print characters unlimited".
Tested on x86_64-linux.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31410
---
gdb/testsuite/gdb.base/startup-with-shell.exp | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp
index d5ec503dceb..670fab6a543 100644
--- a/gdb/testsuite/gdb.base/startup-with-shell.exp
+++ b/gdb/testsuite/gdb.base/startup-with-shell.exp
@@ -66,6 +66,7 @@ with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" {
with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" {
initial_setup_simple "off" "$unique_file_dir/*.unique-extension"
+ gdb_test_no_output "set print characters unlimited"
gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file_dir/\\\*\.unique-extension\"" \
"first argument not expanded"
}
base-commit: 4a4fd10d1707424b9b13aa4af0cec7590c086ea0
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp
2024-02-26 14:17 [PATCH] [gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp Tom de Vries
@ 2024-02-26 14:53 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2024-02-26 14:53 UTC (permalink / raw)
To: Tom de Vries; +Cc: gdb-patches
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Fix this in the same way, using "set print characters unlimited".
Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 14:17 [PATCH] [gdb/testsuite] Further handle long filenames in gdb.base/startup-with-shell.exp Tom de Vries
2024-02-26 14:53 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).