[PATCH 1/1] testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior

[PATCH 1/1] testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior

[Abdul Basit Ijaz]

From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Got a regression email due to merge of commit in CI config
tcwg_gdb_check/master-aarch64 :
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185cd0075bbb1aedf9665685dba0827cfec

Begining of test "gdb.fortran/array-slices-bad.exp" was updated in above
commit to start the test from running to line with tag "First Breakpoint"
instead of "fortran_runto_main".  Reason of the regression is shared
libraries are still loaded after hitting the breakpoint as "nosharedlibrary"
is already called before hitting the breakpoint.

So now after this change test is updated accordingly to disable and unload
shared libraries symbols after hitting the first breakpoint.

2023-09-09 Ijaz, Abdul B <abdul.b.ijaz@intel.com>
---
 gdb/testsuite/gdb.fortran/array-slices-bad.exp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/array-slices-bad.exp b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
index d7b00694539..280628db1b4 100644
--- a/gdb/testsuite/gdb.fortran/array-slices-bad.exp
+++ b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
@@ -25,17 +25,17 @@ if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
     return -1
 }
 
+if {![runto [gdb_get_line_number "First Breakpoint"]]} {
+    perror "couldn't run to breakpoint First Breakpoint"
+    return -1
+}
+
 # Avoid shared lib symbols.
 gdb_test_no_output "set auto-solib-add off"
 
 # Avoid libc symbols, in particular the 'array' type.
 gdb_test_no_output "nosharedlibrary"
 
-if {![runto [gdb_get_line_number "First Breakpoint"]]} {
-    perror "couldn't run to breakpoint First Breakpoint"
-    return -1
-}
-
 gdb_breakpoint [gdb_get_line_number "Second Breakpoint"]
 gdb_breakpoint [gdb_get_line_number "Final Breakpoint"]
 
-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH 1/1] testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior

[Andrew Burgess]

Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org> writes:

> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
>
> Got a regression email due to merge of commit in CI config
> tcwg_gdb_check/master-aarch64 :
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185cd0075bbb1aedf9665685dba0827cfec
>
> Begining of test "gdb.fortran/array-slices-bad.exp" was updated in above
> commit to start the test from running to line with tag "First Breakpoint"
> instead of "fortran_runto_main".  Reason of the regression is shared
> libraries are still loaded after hitting the breakpoint as "nosharedlibrary"
> is already called before hitting the breakpoint.
>
> So now after this change test is updated accordingly to disable and unload
> shared libraries symbols after hitting the first breakpoint.

LGTM.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

>
> 2023-09-09 Ijaz, Abdul B <abdul.b.ijaz@intel.com>
> ---
>  gdb/testsuite/gdb.fortran/array-slices-bad.exp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.fortran/array-slices-bad.exp b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
> index d7b00694539..280628db1b4 100644
> --- a/gdb/testsuite/gdb.fortran/array-slices-bad.exp
> +++ b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
> @@ -25,17 +25,17 @@ if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
>      return -1
>  }
>  
> +if {![runto [gdb_get_line_number "First Breakpoint"]]} {
> +    perror "couldn't run to breakpoint First Breakpoint"
> +    return -1
> +}
> +
>  # Avoid shared lib symbols.
>  gdb_test_no_output "set auto-solib-add off"
>  
>  # Avoid libc symbols, in particular the 'array' type.
>  gdb_test_no_output "nosharedlibrary"
>  
> -if {![runto [gdb_get_line_number "First Breakpoint"]]} {
> -    perror "couldn't run to breakpoint First Breakpoint"
> -    return -1
> -}
> -
>  gdb_breakpoint [gdb_get_line_number "Second Breakpoint"]
>  gdb_breakpoint [gdb_get_line_number "Final Breakpoint"]
>  
> -- 
> 2.34.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928