From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH 2/4] [gdb/build] Fix enum param_types odr violation
Date: Mon, 14 Aug 2023 10:07:39 -0600 [thread overview]
Message-ID: <87r0o5zjxw.fsf@tromey.com> (raw)
In-Reply-To: <20230814111721.31402-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 14 Aug 2023 13:17:19 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> When building gdb with -O2 -flto, I run into:
Tom> ...
Tom> gdb/guile/scm-param.c:121:6: warning: type 'param_types' violates the C++ \
Tom> One Definition Rule [-Wodr]
Tom> enum param_types
Tom> ^
Tom> gdb/python/py-param.c:33:6: note: an enum with different value name is \
Tom> defined in another translation unit
Tom> enum param_types
Tom> ^
Tom> ...
Tom> Fix this by renaming to enum scm_param_types and py_param_types.
Looks good, thanks for taking this on.
Perhaps the -Wodr patches should link to the ODR bug.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-08-14 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 11:17 [PATCH 1/4] [gdb/build] Remove superfluous variable param_types in gdb/python/py-param.c Tom de Vries
2023-08-14 11:17 ` [PATCH 2/4] [gdb/build] Fix enum param_types odr violation Tom de Vries
2023-08-14 16:07 ` Tom Tromey [this message]
2023-08-14 11:17 ` [PATCH 3/4] [gdb/build] Fix struct token_and_value " Tom de Vries
2023-08-14 16:07 ` Tom Tromey
2023-08-14 11:17 ` [PATCH 4/4] [gdb/build] Fix struct token " Tom de Vries
2023-08-14 16:08 ` Tom Tromey
2023-08-14 16:06 ` [PATCH 1/4] [gdb/build] Remove superfluous variable param_types in gdb/python/py-param.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0o5zjxw.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).