From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: detect main function even when there's no matching msymbol
Date: Fri, 09 Oct 2020 12:33:53 -0600 [thread overview]
Message-ID: <87r1q7b65q.fsf@tromey.com> (raw)
In-Reply-To: <20201008150855.2113290-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 8 Oct 2020 16:08:55 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Currently, GDB will only stop the backtrace at the main function if
Andrew> there is a minimal symbol with the matching name. In Fortran programs
Andrew> compiled with gfortran this is not the case. The main function is
Andrew> present in the DWARF, and as marked as DW_AT_main_subprogram, but
Andrew> there's no minimal symbol.
Andrew> This commit extends `inside_main_func` to check the full symbols if no
Andrew> matching minimal symbol is found.
Andrew> There's an updated test case that covers this change.
Andrew> gdb/ChangeLog:
Andrew> * frame.c (inside_main_func): Check full symbols as well as
Andrew> minimal symbols.
This looks good to me. Thank you.
Tom
next prev parent reply other threads:[~2020-10-09 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:08 Andrew Burgess
2020-10-09 18:33 ` Tom Tromey [this message]
2020-10-11 17:45 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1q7b65q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).