Re: [PATCH 0/7] [gdb/build] Fix -std=c++20 issues

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> I tried building gdb using -std=c++20, an ran into a few issues.
Tom> This series contains fixes for most of them.

Thanks for doing this.  I read these & sent one comment.
The rest look ok to me.

Tom> But the other one, in remote_target::thread_info_to_thread_handle remains
Tom> unfixed:
Tom> ...
Tom> gdb::byte_vector
Tom> remote_target::thread_info_to_thread_handle (struct thread_info *tp)
Tom> {
Tom>   remote_thread_info *priv = get_remote_thread_info (tp);
Tom>   return priv->thread_handle;

First, I wonder if we even care about this copying.

But if we do, it could return a const reference and linux-thread-db
could be modified to cache the byte_vector in thread_db_thread_info.

Tom