From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 2/2] [gdb/tui] Delete line buffer when switching to singlekey
Date: Fri, 09 Jun 2023 08:16:19 -0600 [thread overview]
Message-ID: <87sfb090wc.fsf@tromey.com> (raw)
In-Reply-To: <20230606150333.5206-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 6 Jun 2023 17:03:33 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> The SingleKey "d" is supposed run the "down" command.
Tom> Fix this by clearing the readline line buffer when switching to SingleKey
Tom> mode.
I was wondering if saving and restoring the partial text would be
better, but honestly this is better than the status quo, and it's not
clear to me that people switch in and out of SingleKey so much that this
kind of detail would matter.
So, seems good.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-06-09 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 15:03 [PATCH 1/2] [gdb/testsuite] Add test-case gdb.tui/single-key.exp Tom de Vries
2023-06-06 15:03 ` [PATCH 2/2] [gdb/tui] Delete line buffer when switching to singlekey Tom de Vries
2023-06-09 14:16 ` Tom Tromey [this message]
2023-06-09 14:37 ` Tom de Vries
2023-06-09 13:52 ` [PATCH 1/2] [gdb/testsuite] Add test-case gdb.tui/single-key.exp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfb090wc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).