Re: [PATCH] gdb: use libtool in GDB_AC_CHECK_BFD

["Jose E. Marchesi" <jose.marchesi@oracle.com>]

>>>>>> "Jose" == Jose E Marchesi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Jose> About gdb/Makefile.in... dunno, $(ZLIB) is included in CLIBS.  This
> Jose> makes me think GDB uses zlib directly?
>
> Jose> If it doesn't, I think you can remove:
>
> It doesn't directly:
>
>     murgatroyd. git grep 'include.*zlib.h' | grep -v ChangeLog | grep -v '^zlib/'
>     bfd/compress.c:#include <zlib.h>
>     binutils/readelf.c:#include <zlib.h>
>     gas/compress-debug.c:#include <zlib.h>
>     gold/compressed_output.cc:#include <zlib.h>
>     gprofng/src/DbeJarFile.cc:#include "zlib.h"
>     include/ctf-api.h:#include <zlib.h>
>     libbacktrace/ztest.c:#include <zlib.h>
>     libctf/ctf-open.c:#include <zlib.h>
>     libctf/ctf-serialize.c:#include <zlib.h>
>
> Jose> 1) The calls to AM_ZLIB and AC_ZSTD from gdb/configure.ac.
> Jose> 2) The definition of ZLIB and ZLIBINC from gdb/Makefile.in
> Jose> 3) ../config/zlib.m4 from aclocal_m4_deps in gdb/Makefile.in
>
> ... however the use in ctf-api.h seems like it would prevent removing
> some of the configury.  gdb includes this header and so it needs the
> correct -I options to find the in-tree zlib.h.
>
> I don't see why ctf-api.h needs this include, but I essentially don't
> know anything about CTF.

Nick, would it be possible to remove the include of zlib.h from
ctf-api.h?  Even if libctf uses zlib, it would be good to not expose the
dependency in the API header...