From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 5/7] gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate
Date: Tue, 08 Nov 2022 10:43:00 -0700 [thread overview]
Message-ID: <87sfit4a1n.fsf@tromey.com> (raw)
In-Reply-To: <20221107155310.2590069-5-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 7 Nov 2022 10:53:08 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> The assertion
Simon> gdb_assert (m_cached_id != null_frame_id);
Simon> is always true, as comparing equal to null_frame_id is always false
Simon> (it's the first case in frame_id::operator==, not sure why it's not this
Simon> way, but that's what it is).
Simon> Replace the comparison with a call to frame_id_p.
Looks good.
Tom
next prev parent reply other threads:[~2022-11-08 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:53 [PATCH 1/7] gdb: clear other.m_cached_id in frame_info_ptr's move ctor Simon Marchi
2022-11-07 15:53 ` [PATCH 2/7] gdb: add prepare_reinflate/reinflate around print_frame_args in info_frame_command_core Simon Marchi
2022-11-08 9:32 ` Bruno Larsen
2022-11-08 15:55 ` Simon Marchi
2022-11-08 19:39 ` Tom Tromey
2022-11-08 19:55 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 3/7] gdb: move frame_info_ptr method implementations to frame-info.c Simon Marchi
2022-11-08 9:55 ` Bruno Larsen
2022-11-08 17:39 ` Tom Tromey
2022-11-07 15:53 ` [PATCH 4/7] gdb: remove manual frame_info reinflation code in backtrace_command_1 Simon Marchi
2022-11-08 10:14 ` Bruno Larsen
2022-11-08 16:05 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 5/7] gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate Simon Marchi
2022-11-08 17:43 ` Tom Tromey [this message]
2022-11-07 15:53 ` [PATCH 6/7] gdb: add missing prepare_reinflate call in print_frame_info Simon Marchi
2022-11-08 10:28 ` Bruno Larsen
2022-11-08 11:31 ` Lancelot SIX
2022-11-08 16:08 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 7/7] gdb: add special handling for frame level 0 in frame_info_ptr Simon Marchi
2022-11-08 10:40 ` Bruno Larsen
2022-11-08 16:19 ` Simon Marchi
2022-11-10 16:28 ` Bruno Larsen
2022-11-10 16:30 ` Simon Marchi
2022-11-08 8:53 ` [PATCH 1/7] gdb: clear other.m_cached_id in frame_info_ptr's move ctor Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfit4a1n.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).