From: Bruno Larsen <blarsen@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] gdb: move frame_info_ptr method implementations to frame-info.c
Date: Tue, 8 Nov 2022 10:55:20 +0100 [thread overview]
Message-ID: <894cf31a-40dd-b1d4-fd87-e9679e06fec3@redhat.com> (raw)
In-Reply-To: <20221107155310.2590069-3-simon.marchi@polymtl.ca>
On 07/11/2022 16:53, Simon Marchi via Gdb-patches wrote:
> I don't see any particular reason why the implementations of the
> frame_info_ptr object are in the header file. It only seems to add some
> complexity. Since we can't include frame.h in frame-info.h, we have to
> add declarations of functions defined in frame.c, in frame-info.h. By
> moving the implementations to a new frame-info.c, we can avoid that.
My guess is that Tom was prototyping the solution like this, and I
caught it and sent it before finishing his train of thoughts. (That or I
wasn't sure of how to add a new .c file, always a possibility...)
This patch makes sense and generates no build issues or regressions on
my system, so:
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
--
Cheers,
Bruno
next prev parent reply other threads:[~2022-11-08 9:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:53 [PATCH 1/7] gdb: clear other.m_cached_id in frame_info_ptr's move ctor Simon Marchi
2022-11-07 15:53 ` [PATCH 2/7] gdb: add prepare_reinflate/reinflate around print_frame_args in info_frame_command_core Simon Marchi
2022-11-08 9:32 ` Bruno Larsen
2022-11-08 15:55 ` Simon Marchi
2022-11-08 19:39 ` Tom Tromey
2022-11-08 19:55 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 3/7] gdb: move frame_info_ptr method implementations to frame-info.c Simon Marchi
2022-11-08 9:55 ` Bruno Larsen [this message]
2022-11-08 17:39 ` Tom Tromey
2022-11-07 15:53 ` [PATCH 4/7] gdb: remove manual frame_info reinflation code in backtrace_command_1 Simon Marchi
2022-11-08 10:14 ` Bruno Larsen
2022-11-08 16:05 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 5/7] gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate Simon Marchi
2022-11-08 17:43 ` Tom Tromey
2022-11-07 15:53 ` [PATCH 6/7] gdb: add missing prepare_reinflate call in print_frame_info Simon Marchi
2022-11-08 10:28 ` Bruno Larsen
2022-11-08 11:31 ` Lancelot SIX
2022-11-08 16:08 ` Simon Marchi
2022-11-07 15:53 ` [PATCH 7/7] gdb: add special handling for frame level 0 in frame_info_ptr Simon Marchi
2022-11-08 10:40 ` Bruno Larsen
2022-11-08 16:19 ` Simon Marchi
2022-11-10 16:28 ` Bruno Larsen
2022-11-10 16:30 ` Simon Marchi
2022-11-08 8:53 ` [PATCH 1/7] gdb: clear other.m_cached_id in frame_info_ptr's move ctor Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=894cf31a-40dd-b1d4-fd87-e9679e06fec3@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).