public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] gdb: fix using clear command to delete non-user breakpoints(PR cli/7161)
Date: Fri, 15 Apr 2022 10:41:01 -0600	[thread overview]
Message-ID: <87sfqez4de.fsf@tromey.com> (raw)
In-Reply-To: <MEAP282MB029318332185354DA7DF4F15DD129@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM> (Enze Li via Gdb-patches's message of "Thu, 17 Mar 2022 22:24:15 +0800")

>>>>> Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:

> The clear command shouldn't delete momentary and internal breakpoints,
> nor internal breakpoints created via Python's gdb.Breakpoint.

> This patch fixes this issue and adds a testcase.

Thank you for the patch.

> +int
> +main ()
> +{
> +  printf("Hello,world!\n"); /* break here */
> +  return 0;
> +}

There's may be an existing main.c you can just reuse instead of adding a
new file.

> diff --git a/gdb/testsuite/gdb.base/pr7161.exp b/gdb/testsuite/gdb.base/pr7161.exp

We normally don't name tests after bugs, but instead give them a
descriptive name.

Tom

  parent reply	other threads:[~2022-04-15 16:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220314122406.24889-1-lienze2010@hotmail.com>
2022-03-17 14:24 ` Enze Li
2022-03-23 14:25   ` Enze Li
2022-04-14  5:58   ` [PING^2][PATCH " Enze Li
2022-04-15 16:41   ` Tom Tromey [this message]
2022-04-16  3:42     ` [PATCH v3] " Enze Li
2022-04-17 21:26       ` Tom Tromey
2022-04-18 16:04       ` Pedro Alves
2022-04-19 14:07         ` Enze Li
2022-04-22 15:01           ` Pedro Alves
2022-04-18 16:12       ` Tom Tromey
2022-04-19  2:10         ` Enze Li
2022-04-19  3:26           ` Tom Tromey
2022-04-18 23:49       ` Simon Marchi
2022-04-19  3:37         ` Simon Marchi
2022-04-19 13:32           ` Enze Li
2022-04-17  7:18     ` [PATCH RESEND " Enze Li
2022-04-17 22:29       ` Lancelot SIX
2022-04-21 14:29       ` Enze Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfqez4de.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).