public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Enze Li <lienze2010@hotmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, tom@tromey.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb: fix using clear command to delete non-user breakpoints(PR cli/7161)
Date: Tue, 19 Apr 2022 21:32:37 +0800	[thread overview]
Message-ID: <MEAP282MB029383CDDDA0399522F7C1DBDDF29@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <f82021a6-88ab-c063-a1f1-5af98a7de69d@polymtl.ca>

On Mon, 2022-04-18 at 23:37 -0400, Simon Marchi wrote:
> 
> 
> On 2022-04-18 19:49, Simon Marchi via Gdb-patches wrote:
> > 
> > 
> > On 2022-04-15 23:42, Enze Li via Gdb-patches wrote:
> > > The clear command shouldn't delete momentary and internal
> > > breakpoints,
> > > nor internal breakpoints created via Python's gdb.Breakpoint.
> > > 
> > > This patch fixes this issue and adds a testcase.
> > > 
> > > Regression tested on x86_64 openSUSE
> > > Tumbleweed(VERSION_ID="20220413").
> > > 
> > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=7161
> > 
> > Hi,
> > 
> > I see this test failing on Ubuntu 20.04:
> > 
> >  65 maint info break -1^M
> >  66 Num     Type           Disp Enb Address            What^M
> >  67 -1      shlib events   keep n   0x00007ffff7fd2fd1
> > <dl_main+6641> inf 1^M
> >  68 -1.1                        y   0x00007ffff7fd2fd1
> > <dl_main+6641> inf 1^M
> >  69 (gdb) maint info break -1^M
> >  70 Num     Type           Disp Enb Address            What^M
> >  71 -1      shlib events   keep n   0x00007ffff7fd2fd1
> > <dl_main+6641> inf 1^M
> >  72 -1.1                        y   0x00007ffff7fd2fd1
> > <dl_main+6641> inf 1^M
> >  73 (gdb) FAIL: gdb.base/clear_non_user_bp.exp: maint info
> > breakpoint -1 error
> > 
> > Simon
> 
> Sorry for the noise, I didn't see that Tom had already reported that
> failure.
> 
> Simon

Hi Simon,

Any feedback is welcome.  I reproduced the issue on Ubuntu 20.04 you
reported to me.  Thanks a lot.  :)

Enze


  reply	other threads:[~2022-04-19 13:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220314122406.24889-1-lienze2010@hotmail.com>
2022-03-17 14:24 ` [PATCH v2] " Enze Li
2022-03-23 14:25   ` Enze Li
2022-04-14  5:58   ` [PING^2][PATCH " Enze Li
2022-04-15 16:41   ` [PATCH " Tom Tromey
2022-04-16  3:42     ` [PATCH v3] " Enze Li
2022-04-17 21:26       ` Tom Tromey
2022-04-18 16:04       ` Pedro Alves
2022-04-19 14:07         ` Enze Li
2022-04-22 15:01           ` Pedro Alves
2022-04-18 16:12       ` Tom Tromey
2022-04-19  2:10         ` Enze Li
2022-04-19  3:26           ` Tom Tromey
2022-04-18 23:49       ` Simon Marchi
2022-04-19  3:37         ` Simon Marchi
2022-04-19 13:32           ` Enze Li [this message]
2022-04-17  7:18     ` [PATCH RESEND " Enze Li
2022-04-17 22:29       ` Lancelot SIX
2022-04-21 14:29       ` Enze Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MEAP282MB029383CDDDA0399522F7C1DBDDF29@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM \
    --to=lienze2010@hotmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).