From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCHv2] gdb/x86: handle stap probe arguments in xmm registers
Date: Wed, 16 Mar 2022 11:42:58 -0600 [thread overview]
Message-ID: <87sfrhiyjh.fsf@tromey.com> (raw)
In-Reply-To: <20220316141316.465293-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 16 Mar 2022 14:13:16 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> +/* UNOP_EXTRACT takes a value and a type, like a cast, but, instead of
Andrew> + casting the value to the given type, a new value (of the given
Andrew> + type) is extracted from the contents of the old value, starting
Andrew> + from the least significant byte.
Andrew> +
Andrew> + It is invalid for the given type to be larger than the type of the
Andrew> + given value. */
Andrew> +OP (UNOP_EXTRACT)
One thing I meant to mention is that I hope that, someday, we can start
removing the OP_ constants. In most cases they aren't really needed --
there's only a handful of checks for these, I think. Maybe we can have
some kind of OP_NOT_REALLY_THAT_SPECIAL constant that's used instead.
In the meantime this seems fine and normal though.
Tom
prev parent reply other threads:[~2022-03-16 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:54 [PATCH] " Andrew Burgess
2022-03-15 13:53 ` Metzger, Markus T
2022-03-15 17:28 ` Andrew Burgess
2022-03-16 9:36 ` Metzger, Markus T
2022-03-16 10:03 ` Andrew Burgess
2022-03-16 10:29 ` Metzger, Markus T
2022-03-16 14:13 ` [PATCHv2] " Andrew Burgess
2022-03-16 17:23 ` Tom Tromey
2022-03-17 15:54 ` Pedro Alves
2022-03-21 14:41 ` Andrew Burgess
2022-03-16 17:42 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfrhiyjh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).