From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] gdb/x86: handle stap probe arguments in xmm registers
Date: Wed, 16 Mar 2022 10:29:11 +0000 [thread overview]
Message-ID: <DM8PR11MB57495DD6B8D5EE30264AF828DE119@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87czimusd3.fsf@redhat.com>
Hello Andrew,
>> Also, we would need to cast untyped registers to some type for any operation
>like
>> adding stack offsets as in 8@1600(%rbx). It is arguably cleaner as the type now
>> comes from a particular interpretation of the register's content rather than
>from
>> the register itself, but that's maybe hair-splitting.
>
>I don't know what you mean by hair-splitting in this case. This seems
>to be the biggest drawback from this proposal, and for me, I think this
>would be a huge step backwards in user experience.
I was referring to a non-user-visible internal-only change where registers would be
untyped and the type would later be added as the register's content get interpreted.
In the 8@1600(%rbx) example this would look like:
Operation: UNOP_CAST
Operation: UNOP_IND
Operation: UNOP_CAST
Operation: BINOP_ADD
Operation: OP_LONG
Type: long
Constant: 0x0000000000000640
Operation: UNOP_CAST
Operation: OP_REGISTER
String: rbp
Type: uint8_t *
Type: uint64_t *
Type: uint64_t
In the end, this is very similar to the UNOP_EXTRACT you are proposing.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-03-16 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:54 Andrew Burgess
2022-03-15 13:53 ` Metzger, Markus T
2022-03-15 17:28 ` Andrew Burgess
2022-03-16 9:36 ` Metzger, Markus T
2022-03-16 10:03 ` Andrew Burgess
2022-03-16 10:29 ` Metzger, Markus T [this message]
2022-03-16 14:13 ` [PATCHv2] " Andrew Burgess
2022-03-16 17:23 ` Tom Tromey
2022-03-17 15:54 ` Pedro Alves
2022-03-21 14:41 ` Andrew Burgess
2022-03-16 17:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57495DD6B8D5EE30264AF828DE119@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).