From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] Use rust_demangle to fix a crash
Date: Mon, 20 Mar 2023 07:48:14 -0600 [thread overview]
Message-ID: <87ttyfh6u9.fsf@tromey.com> (raw)
In-Reply-To: <87ileveokp.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 20 Mar 2023 09:53:26 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>> + a C++-compatible mangling, so must come before C++; Ada must come
>> + last (see ada_sniff_from_mangled_name). (Keep this order in sync
>> + with the 'languages' array in language.c.) */
Andrew> Could you drop the last bit: "(Keep this order in sync with ...".
Andrew> This is no longer true, the languages array automatically fills itself
Andrew> as the languages are initialised, and always places the entries in the
Andrew> correct order.
Yep, I removed it.
Andrew> Looks good with that change.
Andrew> Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Thanks, I'm going to check it in.
Tom
prev parent reply other threads:[~2023-03-20 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:35 Tom Tromey
2023-03-20 9:53 ` Andrew Burgess
2023-03-20 13:48 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttyfh6u9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).