From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use function view when iterating over block symbols
Date: Tue, 15 Mar 2022 16:17:12 -0600 [thread overview]
Message-ID: <87tuby274n.fsf@tromey.com> (raw)
In-Reply-To: <bd25bef7-d3da-5cd4-92dc-469d194ddf79@polymtl.ca> (Simon Marchi's message of "Tue, 15 Mar 2022 10:54:53 -0400")
Simon> I see some tests failing in gdb.trace since this patch.
Sorry about that.
Simon> I can't really
Simon> explain it, but I tracked it down to this capture by reference.
'pc' is assigned to later in the function. The new closure uses the
updated value, but the old code did not.
I'm checking in the appended. I verified that the test failed before
the patch and passes after. I didn't see this in the original patch
because I didn't run gdbserver tests.
Tom
next prev parent reply other threads:[~2022-03-15 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 23:40 Tom Tromey
2022-03-06 16:27 ` Simon Marchi
2022-03-15 14:54 ` Simon Marchi
2022-03-15 22:17 ` Tom Tromey [this message]
2022-03-15 22:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuby274n.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).