Re: [PATCH v4 04/28] Add to_location method to dwarf_value class

[Tom Tromey <tom@tromey.com>]

>>>>> "Zoran" == Zoran Zaric via Gdb-patches <gdb-patches@sourceware.org> writes:

Zoran> By allowing any location description to be on the DWARF stack, these
Zoran> implicit conversions are expected on per operation basis which means
Zoran> that the new dwarf_value class need to have a support for it.

I don't really follow the meaning of "location description" in this
comment.  For me this term refers to the expression in DWARF, but here
you seem to be using it to refer to some sort of value.

Zoran> This patch adds a conversion method from a dwarf_value object into a
Zoran> location description object.

Zoran> --- a/gdbsupport/common-utils.h
Zoran> +++ b/gdbsupport/common-utils.h
Zoran> @@ -206,4 +206,22 @@ extern int hex2bin (const char *hex, gdb_byte *bin, int count);
Zoran>  /* Like the above, but return a gdb::byte_vector.  */
Zoran>  gdb::byte_vector hex2bin (const char *hex);
 
Zoran> +#if __cplusplus >= 201402L
Zoran> +#include <memory>
Zoran> +
Zoran> +using std::make_unique;
Zoran> +#else
Zoran> +namespace gdb {
Zoran> +
Zoran> +/* Stolen from libstdc++ and adjusted, so probably fine license-wise.  */

I think it's fine to just document that this came from libstdc++.

I tend to think this should go in gdbsupport/gdb_unique_ptr.h.

Tom