From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/9] Ignore unsed import in dap/__init__.py
Date: Wed, 20 Mar 2024 09:35:32 -0600 [thread overview]
Message-ID: <87v85ggbln.fsf@tromey.com> (raw)
In-Reply-To: <20240319-more-flake8-v1-3-893549dbed75@adacore.com> (Tom Tromey's message of "Tue, 19 Mar 2024 11:33:31 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> flake8 warns about dap/__init__.py because it has a number of unused
Tom> imports. Most of these are intentional: the import is done to ensure
Tom> that the a DAP request is registered with the server object.
Tom> This patch applies a "noqa" comment to these imports, and also removes
Tom> one import that is truly unnecessary.
Tom> +from . import breakpoint # noqa: F401
Tom> +from . import bt # noqa: F401
Tom> +from . import disassemble # noqa: F401
I found out 'black' doesn't like this style of comment.
Locally I've run black on each patch in this series, and it affected
just a couple patches like this, removing the extra whitespace.
Tom
next prev parent reply other threads:[~2024-03-20 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 17:33 [PATCH 0/9] Make gdb/python flake-clean Tom Tromey
2024-03-19 17:33 ` [PATCH 1/9] Remove .flake8 Tom Tromey
2024-03-19 17:33 ` [PATCH 2/9] Fix flake8 errors in dap/server.py Tom Tromey
2024-03-19 17:33 ` [PATCH 3/9] Ignore unsed import in dap/__init__.py Tom Tromey
2024-03-20 15:35 ` Tom Tromey [this message]
2024-03-19 17:33 ` [PATCH 4/9] Remove unused import from gdb/__init__.py Tom Tromey
2024-03-19 17:33 ` [PATCH 5/9] Remove bare "except" from disassembler.py Tom Tromey
2024-03-19 17:33 ` [PATCH 6/9] Suppress star import errors Tom Tromey
2024-03-19 17:33 ` [PATCH 7/9] Specify ImportError in styling.py Tom Tromey
2024-03-19 17:33 ` [PATCH 8/9] Suppress some "undefined" warnings from flake8 Tom Tromey
2024-03-20 18:58 ` Simon Marchi
2024-03-20 20:30 ` Tom Tromey
2024-03-20 20:32 ` Tom Tromey
2024-03-19 17:33 ` [PATCH 9/9] Do not use bare "except" Tom Tromey
2024-03-20 19:01 ` [PATCH 0/9] Make gdb/python flake-clean Simon Marchi
2024-04-02 17:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v85ggbln.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).