public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,
	 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: The defs.h / common-defs.h / server.h rule
Date: Tue, 27 Feb 2024 07:54:31 -0700	[thread overview]
Message-ID: <87v86aufdk.fsf@tromey.com> (raw)
In-Reply-To: <baee4c1c-6b79-4dd2-9d33-70e28085750b@polymtl.ca> (Simon Marchi's message of "Fri, 23 Feb 2024 16:55:10 -0500")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> On 2024-02-23 16:06, Tom Tromey wrote:
Simon> I suppose the other classic way to do this is with an -include flag,
Simon> passed to the compiler?

>> I don't know if any projects do this, but traditionally it's not done by
>> GNU-ish programs, I guess because -include was GCC-specific, i.e., not
>> portable.

Simon> Do you think it would be acceptable today?  As far as I know, people
Simon> only build gdb with gcc and clang.

I've tried to think of a reason we shouldn't do it, but I haven't really
come up with anything compelling.

It's hard to really know if it would cause problems for someone.
However it seems to me that you could do the experiment.  Worst case,
we'd have to back it out any maybe add some #includes here and there.

Tom

      reply	other threads:[~2024-02-27 14:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2f2f552a-0028-49cc-adbe-ca038c1e9acd@polymtl.ca>
2024-02-20 12:20 ` Andrew Burgess
2024-02-20 14:52 ` Tom Tromey
2024-02-20 15:14   ` Tom Tromey
2024-02-23 20:35   ` Simon Marchi
2024-02-23 21:06     ` Tom Tromey
2024-02-23 21:55       ` Simon Marchi
2024-02-27 14:54         ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v86aufdk.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).