public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: The defs.h / common-defs.h / server.h rule
Date: Tue, 20 Feb 2024 08:14:18 -0700	[thread overview]
Message-ID: <87v86j2mnp.fsf@tromey.com> (raw)
In-Reply-To: <87zfvv2non.fsf@tromey.com> (Tom Tromey's message of "Tue, 20 Feb 2024 07:52:08 -0700")

Simon> Could we switch to having headers include what they use?

Tom> Do you mean just adding defs.h to every header, or something else?

To be clear here, I think adding defs.h (or whatever) to every header
seems relatively harmless.  So if that would help you, it seems ok.

Simon> Before someome says "it's your tools' fault, your tools are bad": I
Simon> know.

Tom> In addition to that, I wonder how to enforce this rule.
Tom> For example I'm not likely to start using clangd.
Tom> Or if clangd is changed, will the rule change?

... just that I suspect you'll end up having to remind me of the rule
from time to time.

Tom

  reply	other threads:[~2024-02-20 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2f2f552a-0028-49cc-adbe-ca038c1e9acd@polymtl.ca>
2024-02-20 12:20 ` Andrew Burgess
2024-02-20 14:52 ` Tom Tromey
2024-02-20 15:14   ` Tom Tromey [this message]
2024-02-23 20:35   ` Simon Marchi
2024-02-23 21:06     ` Tom Tromey
2024-02-23 21:55       ` Simon Marchi
2024-02-27 14:54         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v86j2mnp.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).