From: Andrew Burgess <aburgess@redhat.com>
To: Simon Marchi <simark@simark.ca>,
Klaus Gerlicher <klaus.gerlicher@intel.com>,
simon.marchi@efficios.com
Cc: Simon.Marchi@amd.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: reject inserting breakpoints between functions
Date: Wed, 08 May 2024 15:26:50 +0100 [thread overview]
Message-ID: <87wmo4s7kl.fsf@redhat.com> (raw)
In-Reply-To: <d2942f9e-b43b-409b-9a81-37d17997f435@simark.ca>
Simon Marchi <simark@simark.ca> writes:
> On 2024-05-01 05:47, Andrew Burgess wrote:
>> Klaus Gerlicher <klaus.gerlicher@intel.com> writes:
>>
>>> Hi Simon,
>>>
>>> I verified that your patch addresses many of the issues we would also
>>> like to solve in this area.
>>>
>>> It appears this has not published yet and it seems to be more than 2
>>> years old.
>>>
>>> Could you please tell me if there are any plans to commit this?
>>
>> Given I reviewed this once upon a time, I still had my review branch
>> kicking around.
>>
>> I rebased onto something close to HEAD of master. I addressed the minor
>> nits I pointed out in my review. I'd be happy to see this merged once
>> my full regression run (still on going) has completed.
>>
>> I think I'd like Simon to give a +1 before I pushed this though.
>>
>> Thanks,
>> Andrew
>
> Thanks for reminding me about this, it clearly fell through the cracks.
> And thanks Andrew for following up on it. What you posted looks good to
> me. We discussed it internally, Pedro suggested to maybe wait after the
> GDB 15 branch is created before pushing this one, to give it more
> testing time in master before it reaches a release.
Fine with me. Feel free to pick this back up yourself if it's still of
interest to you. I'll add it to my "todo" pile and revisit in a month
or so if I don't see any activity.
Thanks,
Andrew
prev parent reply other threads:[~2024-05-08 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 20:05 Simon Marchi
2022-06-17 16:25 ` Lancelot SIX
2022-06-21 17:01 ` Andrew Burgess
2024-04-30 8:47 ` Klaus Gerlicher
[not found] ` <6630b03f.050a0220.6a68d.6289SMTPIN_ADDED_BROKEN@mx.google.com>
2024-05-01 9:47 ` Andrew Burgess
2024-05-01 18:11 ` Simon Marchi
2024-05-08 14:26 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmo4s7kl.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=Simon.Marchi@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=klaus.gerlicher@intel.com \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).