From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Implement some agent expressions for Ada
Date: Mon, 09 Jan 2023 08:49:44 -0700 [thread overview]
Message-ID: <87wn5vaesn.fsf@tromey.com> (raw)
In-Reply-To: <2e2d19cc-bf4e-4ac7-902f-4ad0a7348e5f@simark.ca> (Simon Marchi's message of "Fri, 6 Jan 2023 16:38:05 -0500")
>> + std::get<0> (m_storage)->generate_ax (exp, ax, value, cast_type);
>> +
>> + struct type *type = value->type;
>> + if (ada_is_aligner_type (type))
>> + error (_("Aligner types cannot be handled in agent expressions"));
>> + else if (find_base_type (type) != nullptr)
>> + error (_("Dynamic types cannot be handled in agent expressions"));
Simon> Is it on purpose that you do these checks after calling generate_ax?
It's intentional, because it is the type of the wrapped value that is
being checked.
Tom
next prev parent reply other threads:[~2023-01-09 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 16:44 [PATCH 0/2] Add some agent expression support " Tom Tromey
2023-01-04 16:44 ` [PATCH 1/2] Implement some agent expressions " Tom Tromey
2023-01-06 21:38 ` Simon Marchi
2023-01-09 15:49 ` Tom Tromey [this message]
2023-01-04 16:44 ` [PATCH 2/2] Handle range types in ax-gdb.c Tom Tromey
2023-01-06 21:51 ` Simon Marchi
2023-01-09 16:11 ` Tom Tromey
2023-02-27 15:03 ` [PATCH 0/2] Add some agent expression support for Ada Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn5vaesn.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).