From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>, ro@gcc.gnu.org
Subject: Re: [PATCH] gdb: fix symtab.c build on 32 bit targets
Date: Fri, 18 Nov 2022 08:37:51 -0700 [thread overview]
Message-ID: <87wn7sqnn4.fsf@tromey.com> (raw)
In-Reply-To: <20221117183226.1632406-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 17 Nov 2022 13:32:26 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> PR 29798 shows a similar error message but on Solaris.
It should say "PR build/29798" here, so the commit script can pick it
up.
Simon> Work around that by using string_printf. It is a good thing to get rid
Simon> of the alloca anyway.
Indeed. IMO alloca should be poisoned.
The patch looks good to me.
Simon> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29798
... we should teach that commit script to pick this up.
I don't know how to access it, though.
Tom
next prev parent reply other threads:[~2022-11-18 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:32 Simon Marchi
2022-11-18 15:37 ` Tom Tromey [this message]
2022-11-18 15:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn7sqnn4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=ro@gcc.gnu.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).